Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reuse errgroup in domain event informer #824

Merged
merged 1 commit into from
Feb 15, 2024
Merged

fix: reuse errgroup in domain event informer #824

merged 1 commit into from
Feb 15, 2024

Conversation

Ubisoft-potato
Copy link
Collaborator

Fixes #823

@Ubisoft-potato Ubisoft-potato marked this pull request as ready for review February 15, 2024 11:13
cre8ivejp
cre8ivejp approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@cre8ivejp cre8ivejp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cre8ivejp cre8ivejp merged commit f768521 into bucketeer-io:main Feb 15, 2024
10 checks passed
@bucketeer-bot bucketeer-bot mentioned this pull request Feb 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cre8ivejp cre8ivejp cre8ivejp approved these changes

@kentakozuka kentakozuka Awaiting requested review from kentakozuka kentakozuka is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

investigate: messages are not nacked from pubsub randomly
2 participants
@Ubisoft-potato @cre8ivejp