Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #821
After the Organization implementation, we must use the
url_code
instead ofenvironment_id
for all URLs.I fixed it to use the
urlCode
and addedenvironmentName
to the notification, too.This pull request mainly involves changes in the
pkg/batch/jobs/notification/domain_event_informer.go
andpkg/notification/sender/notifier/slack.go
files, with changes focusing on the replacement ofenvironmentID
withenvironmentName
andenvironmentURLCode
. This is reflected in the creation of notification events, handling of messages, and logging. Test files have been updated to reflect these changes. Additional logging has also been added inpkg/eventpersister/persister/persister.go
.Changes to
domain_event_informer.go
:DomainEventInformer
fails to pull a message from the message channel.environmentID
withenvironmentName
andenvironmentURLCode
inhandleMessage
andcreateNotificationEvent
methods. [1] [2] [3] [4]Changes to
domain_event_test.go
:environmentName
andenvironmentURLCode
instead ofenvironmentID
. [1] [2] [3] [4]Changes to other files:
environmentID
withenvironmentName
andenvironmentURLCode
in various files and methods. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16]pkg/eventpersister/persister/persister.go
when the update evaluation count timer is triggered.