Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep tools up-to-date when run #12

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Keep tools up-to-date when run #12

wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jun 10, 2024

By default, tools invoke bazel build in a way that minimizes latency before being run to ensure that they are up-to-date. The new update_when_run attribute can be used to tweak this behavior.

By default, tools invoke `bazel build` in a way that minimizes latency before being run to ensure that they are up-to-date.
The new `update_when_run` attribute can be used to tweak this behavior.
@fmeum fmeum marked this pull request as draft June 10, 2024 13:02
@fmeum fmeum marked this pull request as draft June 10, 2024 13:02
@fmeum fmeum requested review from sluongng and bduffany June 10, 2024 20:00
@fmeum
Copy link
Collaborator Author

fmeum commented Jun 10, 2024

I haven't updated the README yet, but if you have any thoughts on this @bduffany @sluongng, let me know. It's hard to find the right balance between latency and correctness.

Copy link
Member

@bduffany bduffany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM - I think the "auto" behavior is probably a good balance for our repo since tool deps like NPM etc. don't change very often.

Also, I think it'd be cool to enable this in the buildbuddy repo to start collecting feedback (if other folks in #eng are open to it) - go / npm / yarn might be good places to start. Another good use case might be the bb command - we currently have a cli/dev.sh script but it might be cool to add bb-dev to PATH as another way to invoke the CLI from source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants