Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: glob should fail if 0 files are returned? #137

Closed
nickatsegment opened this issue Jun 6, 2020 · 1 comment · Fixed by #179
Closed

bug: glob should fail if 0 files are returned? #137

nickatsegment opened this issue Jun 6, 2020 · 1 comment · Fixed by #179

Comments

@nickatsegment
Copy link

If the test job fails to generate a report for some reason, and you're using a wildcard to glob for the report, this plugin will report success, even though 0 tests were reported.

I'd say it should fail if there are 0 files returned by the glob and/or 0 tests reported. I'd argue this should happen whether fail-build-on-error is set or not, but that's debatable.

@pzeballos pzeballos added the bug label Dec 31, 2021
@toote
Copy link
Contributor

toote commented Oct 15, 2022

Reviewed the code of the plugin and if the glob finds no artifacts the command will fail anyways.

So that leaves the other scenario: empty files or no run tests. Which means that this is a feature request for a "minimum amount of tests" to report about

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants