Allow env vars to control debug logging for the lambda #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJosh9000
approved these changes
Dec 4, 2023
| @@ -57,6 +57,12 @@ func Handler(ctx context.Context, evt json.RawMessage) (string, error) { | |||
| quiet := quietString == "1" || quietString == "true" | |||
| timeout := os.Getenv("BUILDKITE_AGENT_METRICS_TIMEOUT") | |||
|
|
|||
| debugEnvVar := os.Getenv("BUILDKITE_AGENT_METRICS_DEBUG") | |||
| debug := debugEnvVar == "1" || debugEnvVar == "true" | |||
There was a problem hiding this comment.
I think, one day, we should use strconv.ParseBool for all these.
There was a problem hiding this comment.
I kinda wish it were stricter, if it only accepted "true" and "false" and errored on everything else, I would be more happy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, these were hard coded to be off. Now, they can be controlled with env vars.
For the non lambda mode, there are already command line arguments for these.