fix to remove reset in prometheus backend #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been reoved as it can't work for more than one cluster as gauges are scoped to all clusters, but the collect function is called once for each cluster. In summary this leads to gauges only being correct for the last cluster, depending what metrics were returned when the cluster was polled as the result doesn't always include all keys.
patrobinson
approved these changes
Jul 22, 2024
This was referenced Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been reoved as it can't work for more than one cluster as gauges are scoped to all clusters, but the collect function is called once for each agent token. In summary this leads to gauges only being correct for the last agent, depending what metrics were returned when the cluster was polled as the result doesn't always include all keys. 😭
Also trimmed the pipeline metrics as they aren't used, and ensured the logger included short file name as it is helpful.
Added some comments to ensure my assumptions are captured and avoid confusion in the future.