-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change from Glide 4.2.0 to 4.3.0 = crash. Revert to 4.2.0 and all is fine again #2548
Comments
Do you have GlideModule? Can you please include a Glide load line you're using? (If you can narrow down which one is crashing) |
In the future please be careful when you're posting logs or stacks on GitHub, you just mentioned 60 issues which are not related to this one. See for example #10. Always wrap logs in triple backticks (code block) |
Not using a GlideModule |
Why are you using a custom ViewTarget? It looks like you're not implementing I haven't specifically seen It's also possible something changed with how we handle Bitmap re-use that broke something in 4.3 I can't think of anything off the top of my head. If you do have a sample app you can reproduce this in that would definitely help. |
I found a bug I caused in 4.3.0, but it will only affect loads with transformations. Can you confirm that you're not using transformations at all? |
The bug I mentioned above should be fixed in 2371aa6. If you're up for testing it, you can do so by adding a SNAPSHOT dependency on 4.4.0-20171102.052437-3 or higher. |
I'm going to assume this is fixed by 2371aa6, if you get the chance to test this, let me know. |
I tried `implementation 'com.github.bumptech.glide:glide:4.4.0-20171102.183621-4'`
Still crashes
On Thursday, November 2, 2017, 7:25:28 PM CDT, Sam <[email protected]> wrote:
I'm going to assume this is fixed by 2371aa6, if you get the chance to test this, let me know.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Are you able to answer any of the questions above? Can you reproduce this in a sample app and attach it here? |
It would also help if you're able to attach one of the images that triggers the crash. |
Actually it looks like you might have manually enabled the open gl rendered in developer settings? If so that's an experimental setting, try disabling it. |
This is the placeholder image I am using. I will have track down the Amazon image if that will not trigger it for you. All code is Kotlin, doubt that makes any difference. App has full sign in for images it uses so making a sample app is a bit more difficult. I don't have anything enabled in Developer Options under the Drawing area so I don't think Open GL is part of it. |
Thanks for the placeholder. I'm not able to reproduce when using it as a placeholder or as the model on an x86 API 26 emulator on osx. |
Android Studio 3.0
MacBook High Sierra 10.13.1
Android emulator Nexus 5X API level 26
Run app using
implementation 'com.github.bumptech.glide:glide:4.2.0'
Everything is fine but change to
implementation 'com.github.bumptech.glide:glide:4.3.0'
and it crashes for any image I attempt to display. Images are JPG files hosted by Amazon (cloudfront.net)
Placeholder image is 256x256 32-bit color PNG in the APK
Change back to 4.2.0, sync gradle, build app and it works perfectly again
The text was updated successfully, but these errors were encountered: