Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListPreloader.cancelAll does not cancel the most recent request #3693

Closed
technoir42 opened this issue Jun 4, 2019 · 1 comment
Closed

ListPreloader.cancelAll does not cancel the most recent request #3693

technoir42 opened this issue Jun 4, 2019 · 1 comment
Labels

Comments

@technoir42
Copy link
Contributor

Preload queue has size of maxPreload + 1 but only the first maxPreload requests get cancelled. The most recent request is always the last in queue so it doesn't get cancelled.

  private void cancelAll() {
    for (int i = 0; i < maxPreload; i++) {
      requestManager.clear(preloadTargetQueue.next(0, 0));
    }
  }
@sjudd sjudd added the bug label Jun 6, 2019
@sjudd
Copy link
Collaborator

sjudd commented Jun 6, 2019

Thanks for reporting, please feel free to send a pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants