From 5f2b51a38753bae6b718a85835f29f3cc43456d5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=B3bert=20Papp=20=28TWiStErRob=29?= Date: Wed, 26 Jul 2023 13:11:55 +0100 Subject: [PATCH 1/7] Remove unused Issue id: GradleOverrides This minSdkVersion value (...) is not used; it is always overridden by the value specified in the Gradle build script (...) Inspection info: The value of (for example) minSdkVersion is only used if it is not specified in the build.gradle build scripts. When specified in the Gradle build scripts, the manifest value is ignored and can be misleading, so should be removed to avoid ambiguity. --- integration/compose/src/main/AndroidManifest.xml | 1 - integration/sqljournaldiskcache/src/main/AndroidManifest.xml | 1 - 2 files changed, 2 deletions(-) diff --git a/integration/compose/src/main/AndroidManifest.xml b/integration/compose/src/main/AndroidManifest.xml index c1d8467ae6..d6dd9b73a5 100644 --- a/integration/compose/src/main/AndroidManifest.xml +++ b/integration/compose/src/main/AndroidManifest.xml @@ -1,5 +1,4 @@ - \ No newline at end of file diff --git a/integration/sqljournaldiskcache/src/main/AndroidManifest.xml b/integration/sqljournaldiskcache/src/main/AndroidManifest.xml index 7c0d043ed1..3407c4b980 100644 --- a/integration/sqljournaldiskcache/src/main/AndroidManifest.xml +++ b/integration/sqljournaldiskcache/src/main/AndroidManifest.xml @@ -1,5 +1,4 @@ - \ No newline at end of file From e8b17304a05665a598c3ff88521be8054a828536 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=B3bert=20Papp=20=28TWiStErRob=29?= Date: Wed, 26 Jul 2023 13:22:15 +0100 Subject: [PATCH 2/7] Remove empty nodes from manifest. --- annotation/compiler/test/src/main/AndroidManifest.xml | 1 - benchmark/src/main/AndroidManifest.xml | 1 - integration/concurrent/src/main/AndroidManifest.xml | 3 --- integration/cronet/src/test/AndroidManifest.xml | 1 - integration/gifencoder/src/main/AndroidManifest.xml | 3 --- integration/okhttp/src/main/AndroidManifest.xml | 2 -- integration/okhttp4/src/main/AndroidManifest.xml | 2 -- integration/recyclerview/src/main/AndroidManifest.xml | 1 - library/src/main/AndroidManifest.xml | 1 - library/test/src/main/AndroidManifest.xml | 1 - mocks/src/main/AndroidManifest.xml | 1 - testutil/src/main/AndroidManifest.xml | 1 - third_party/disklrucache/src/main/AndroidManifest.xml | 2 -- third_party/gif_decoder/src/main/AndroidManifest.xml | 2 -- third_party/gif_encoder/src/main/AndroidManifest.xml | 1 - 15 files changed, 23 deletions(-) diff --git a/annotation/compiler/test/src/main/AndroidManifest.xml b/annotation/compiler/test/src/main/AndroidManifest.xml index a41245187e..8fd022ed82 100644 --- a/annotation/compiler/test/src/main/AndroidManifest.xml +++ b/annotation/compiler/test/src/main/AndroidManifest.xml @@ -1,4 +1,3 @@ - diff --git a/benchmark/src/main/AndroidManifest.xml b/benchmark/src/main/AndroidManifest.xml index ef40b9d17a..8ca989a1b8 100644 --- a/benchmark/src/main/AndroidManifest.xml +++ b/benchmark/src/main/AndroidManifest.xml @@ -1,4 +1,3 @@ - diff --git a/integration/concurrent/src/main/AndroidManifest.xml b/integration/concurrent/src/main/AndroidManifest.xml index 92c8e1f5d7..b2592a5606 100644 --- a/integration/concurrent/src/main/AndroidManifest.xml +++ b/integration/concurrent/src/main/AndroidManifest.xml @@ -1,6 +1,3 @@ - - - diff --git a/integration/cronet/src/test/AndroidManifest.xml b/integration/cronet/src/test/AndroidManifest.xml index 0f9d016ef7..8f379fcd1d 100644 --- a/integration/cronet/src/test/AndroidManifest.xml +++ b/integration/cronet/src/test/AndroidManifest.xml @@ -1,7 +1,6 @@ - diff --git a/integration/gifencoder/src/main/AndroidManifest.xml b/integration/gifencoder/src/main/AndroidManifest.xml index c2b8a91b37..c300a458ba 100644 --- a/integration/gifencoder/src/main/AndroidManifest.xml +++ b/integration/gifencoder/src/main/AndroidManifest.xml @@ -1,6 +1,3 @@ - - - diff --git a/integration/okhttp/src/main/AndroidManifest.xml b/integration/okhttp/src/main/AndroidManifest.xml index 62fac40a32..9d04a77fc6 100644 --- a/integration/okhttp/src/main/AndroidManifest.xml +++ b/integration/okhttp/src/main/AndroidManifest.xml @@ -1,5 +1,3 @@ - - diff --git a/integration/okhttp4/src/main/AndroidManifest.xml b/integration/okhttp4/src/main/AndroidManifest.xml index 9ad5e952bf..ff01dd0a5a 100644 --- a/integration/okhttp4/src/main/AndroidManifest.xml +++ b/integration/okhttp4/src/main/AndroidManifest.xml @@ -1,5 +1,3 @@ - - \ No newline at end of file diff --git a/integration/recyclerview/src/main/AndroidManifest.xml b/integration/recyclerview/src/main/AndroidManifest.xml index ec07ec85f9..f75b8b17f1 100644 --- a/integration/recyclerview/src/main/AndroidManifest.xml +++ b/integration/recyclerview/src/main/AndroidManifest.xml @@ -1,5 +1,4 @@ - diff --git a/library/src/main/AndroidManifest.xml b/library/src/main/AndroidManifest.xml index d8b515902b..e6b958c93c 100644 --- a/library/src/main/AndroidManifest.xml +++ b/library/src/main/AndroidManifest.xml @@ -1,5 +1,4 @@ - diff --git a/library/test/src/main/AndroidManifest.xml b/library/test/src/main/AndroidManifest.xml index 600ac91f9c..3ab9ba3da8 100644 --- a/library/test/src/main/AndroidManifest.xml +++ b/library/test/src/main/AndroidManifest.xml @@ -1,4 +1,3 @@ - diff --git a/mocks/src/main/AndroidManifest.xml b/mocks/src/main/AndroidManifest.xml index 35b3d02288..53865be9b0 100644 --- a/mocks/src/main/AndroidManifest.xml +++ b/mocks/src/main/AndroidManifest.xml @@ -1,4 +1,3 @@ - diff --git a/testutil/src/main/AndroidManifest.xml b/testutil/src/main/AndroidManifest.xml index 4f9b7f265f..eaebc65841 100644 --- a/testutil/src/main/AndroidManifest.xml +++ b/testutil/src/main/AndroidManifest.xml @@ -1,5 +1,4 @@ - diff --git a/third_party/disklrucache/src/main/AndroidManifest.xml b/third_party/disklrucache/src/main/AndroidManifest.xml index 20eaad4e78..8bcbcb2b3c 100644 --- a/third_party/disklrucache/src/main/AndroidManifest.xml +++ b/third_party/disklrucache/src/main/AndroidManifest.xml @@ -1,6 +1,4 @@ - - diff --git a/third_party/gif_decoder/src/main/AndroidManifest.xml b/third_party/gif_decoder/src/main/AndroidManifest.xml index 9bdfa020a6..78a9ab57cd 100644 --- a/third_party/gif_decoder/src/main/AndroidManifest.xml +++ b/third_party/gif_decoder/src/main/AndroidManifest.xml @@ -1,6 +1,4 @@ - - diff --git a/third_party/gif_encoder/src/main/AndroidManifest.xml b/third_party/gif_encoder/src/main/AndroidManifest.xml index 0b4b09c397..9d5916bf17 100644 --- a/third_party/gif_encoder/src/main/AndroidManifest.xml +++ b/third_party/gif_encoder/src/main/AndroidManifest.xml @@ -1,5 +1,4 @@ - From 677321f599d09b99bbd1b83b776dd6b4176c870f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=B3bert=20Papp=20=28TWiStErRob=29?= Date: Wed, 26 Jul 2023 13:24:44 +0100 Subject: [PATCH 3/7] Remove unused manifest file. --- third_party/gif_encoder/src/main/AndroidManifest.xml | 4 ---- 1 file changed, 4 deletions(-) delete mode 100644 third_party/gif_encoder/src/main/AndroidManifest.xml diff --git a/third_party/gif_encoder/src/main/AndroidManifest.xml b/third_party/gif_encoder/src/main/AndroidManifest.xml deleted file mode 100644 index 9d5916bf17..0000000000 --- a/third_party/gif_encoder/src/main/AndroidManifest.xml +++ /dev/null @@ -1,4 +0,0 @@ - - - From 3bee8853a9425a27f3cf25fdb5b408b7059936c4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=B3bert=20Papp=20=28TWiStErRob=29?= Date: Wed, 26 Jul 2023 13:29:00 +0100 Subject: [PATCH 4/7] Add missing `` in all AndroidManifest.xml files. --- annotation/compiler/test/src/main/AndroidManifest.xml | 1 + instrumentation/src/main/AndroidManifest.xml | 1 + integration/avif/src/main/AndroidManifest.xml | 1 + integration/concurrent/src/main/AndroidManifest.xml | 1 + integration/cronet/src/main/AndroidManifest.xml | 1 + integration/gifencoder/src/main/AndroidManifest.xml | 1 + integration/okhttp/src/main/AndroidManifest.xml | 1 + integration/okhttp3/src/main/AndroidManifest.xml | 1 + integration/okhttp4/src/main/AndroidManifest.xml | 1 + mocks/src/main/AndroidManifest.xml | 1 + 10 files changed, 10 insertions(+) diff --git a/annotation/compiler/test/src/main/AndroidManifest.xml b/annotation/compiler/test/src/main/AndroidManifest.xml index 8fd022ed82..2aa011166d 100644 --- a/annotation/compiler/test/src/main/AndroidManifest.xml +++ b/annotation/compiler/test/src/main/AndroidManifest.xml @@ -1,3 +1,4 @@ + diff --git a/instrumentation/src/main/AndroidManifest.xml b/instrumentation/src/main/AndroidManifest.xml index b1c2f79e71..ebb809527c 100644 --- a/instrumentation/src/main/AndroidManifest.xml +++ b/instrumentation/src/main/AndroidManifest.xml @@ -1,3 +1,4 @@ + diff --git a/integration/avif/src/main/AndroidManifest.xml b/integration/avif/src/main/AndroidManifest.xml index 9819bc0c1c..f9a0793e83 100644 --- a/integration/avif/src/main/AndroidManifest.xml +++ b/integration/avif/src/main/AndroidManifest.xml @@ -1,2 +1,3 @@ + diff --git a/integration/concurrent/src/main/AndroidManifest.xml b/integration/concurrent/src/main/AndroidManifest.xml index b2592a5606..eaa43d41bf 100644 --- a/integration/concurrent/src/main/AndroidManifest.xml +++ b/integration/concurrent/src/main/AndroidManifest.xml @@ -1,3 +1,4 @@ + diff --git a/integration/cronet/src/main/AndroidManifest.xml b/integration/cronet/src/main/AndroidManifest.xml index e13bb2f8ae..58ceb6f056 100644 --- a/integration/cronet/src/main/AndroidManifest.xml +++ b/integration/cronet/src/main/AndroidManifest.xml @@ -1,3 +1,4 @@ + diff --git a/integration/gifencoder/src/main/AndroidManifest.xml b/integration/gifencoder/src/main/AndroidManifest.xml index c300a458ba..97283b03de 100644 --- a/integration/gifencoder/src/main/AndroidManifest.xml +++ b/integration/gifencoder/src/main/AndroidManifest.xml @@ -1,3 +1,4 @@ + diff --git a/integration/okhttp/src/main/AndroidManifest.xml b/integration/okhttp/src/main/AndroidManifest.xml index 9d04a77fc6..0093fcb2ce 100644 --- a/integration/okhttp/src/main/AndroidManifest.xml +++ b/integration/okhttp/src/main/AndroidManifest.xml @@ -1,3 +1,4 @@ + diff --git a/integration/okhttp3/src/main/AndroidManifest.xml b/integration/okhttp3/src/main/AndroidManifest.xml index bc8e5a72c3..787fc70b1d 100644 --- a/integration/okhttp3/src/main/AndroidManifest.xml +++ b/integration/okhttp3/src/main/AndroidManifest.xml @@ -1,3 +1,4 @@ + diff --git a/integration/okhttp4/src/main/AndroidManifest.xml b/integration/okhttp4/src/main/AndroidManifest.xml index ff01dd0a5a..cebf302eef 100644 --- a/integration/okhttp4/src/main/AndroidManifest.xml +++ b/integration/okhttp4/src/main/AndroidManifest.xml @@ -1,3 +1,4 @@ + \ No newline at end of file diff --git a/mocks/src/main/AndroidManifest.xml b/mocks/src/main/AndroidManifest.xml index 53865be9b0..ccdd43b056 100644 --- a/mocks/src/main/AndroidManifest.xml +++ b/mocks/src/main/AndroidManifest.xml @@ -1,3 +1,4 @@ + From 7fe88315c3cc37be9e7711924a81c1fb0916daef Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=B3bert=20Papp=20=28TWiStErRob=29?= Date: Wed, 26 Jul 2023 13:33:03 +0100 Subject: [PATCH 5/7] Ensure one new line at end of modified files. --- annotation/compiler/test/build.gradle | 1 - annotation/ksp/integrationtest/build.gradle | 2 +- annotation/ksp/integrationtest/src/main/AndroidManifest.xml | 2 +- annotation/ksp/test/build.gradle | 2 +- annotation/ksp/test/src/main/AndroidManifest.xml | 2 +- benchmark/build.gradle | 2 +- benchmark/src/androidTest/AndroidManifest.xml | 2 +- instrumentation/build.gradle | 1 - integration/compose/src/main/AndroidManifest.xml | 2 +- integration/cronet/src/test/AndroidManifest.xml | 1 - integration/ktx/src/main/AndroidManifest.xml | 2 +- integration/okhttp4/src/main/AndroidManifest.xml | 2 +- integration/sqljournaldiskcache/src/main/AndroidManifest.xml | 2 +- samples/imgur/build.gradle | 1 - samples/imgur/src/main/AndroidManifest.xml | 2 +- 15 files changed, 11 insertions(+), 15 deletions(-) diff --git a/annotation/compiler/test/build.gradle b/annotation/compiler/test/build.gradle index 925402b22c..ec8529e83c 100644 --- a/annotation/compiler/test/build.gradle +++ b/annotation/compiler/test/build.gradle @@ -94,4 +94,3 @@ task regenerateTestResources { afterEvaluate { regenerateTestResources.finalizedBy(testReleaseUnitTest) } - diff --git a/annotation/ksp/integrationtest/build.gradle b/annotation/ksp/integrationtest/build.gradle index 16ee4b0d07..6b379e0a51 100644 --- a/annotation/ksp/integrationtest/build.gradle +++ b/annotation/ksp/integrationtest/build.gradle @@ -35,4 +35,4 @@ dependencies { testImplementation libs.truth testImplementation libs.kotlin.test testImplementation project(path: ':annotation:ksp:test') -} \ No newline at end of file +} diff --git a/annotation/ksp/integrationtest/src/main/AndroidManifest.xml b/annotation/ksp/integrationtest/src/main/AndroidManifest.xml index 0ffb83e81e..edf12fb1a5 100644 --- a/annotation/ksp/integrationtest/src/main/AndroidManifest.xml +++ b/annotation/ksp/integrationtest/src/main/AndroidManifest.xml @@ -2,4 +2,4 @@ - \ No newline at end of file + diff --git a/annotation/ksp/test/build.gradle b/annotation/ksp/test/build.gradle index 8de75bffa7..292dcd5b92 100644 --- a/annotation/ksp/test/build.gradle +++ b/annotation/ksp/test/build.gradle @@ -22,4 +22,4 @@ dependencies { testImplementation project(":annotation") testImplementation project(":glide") testImplementation libs.kotlin.test -} \ No newline at end of file +} diff --git a/annotation/ksp/test/src/main/AndroidManifest.xml b/annotation/ksp/test/src/main/AndroidManifest.xml index 24d1ba23d8..91d7cf5740 100644 --- a/annotation/ksp/test/src/main/AndroidManifest.xml +++ b/annotation/ksp/test/src/main/AndroidManifest.xml @@ -2,4 +2,4 @@ - \ No newline at end of file + diff --git a/benchmark/build.gradle b/benchmark/build.gradle index e5022d06ee..fb9768b80f 100644 --- a/benchmark/build.gradle +++ b/benchmark/build.gradle @@ -41,4 +41,4 @@ dependencies { androidTestImplementation project(':testutil') androidTestImplementation libs.androidx.benchmark.junit androidTestImplementation libs.guava -} \ No newline at end of file +} diff --git a/benchmark/src/androidTest/AndroidManifest.xml b/benchmark/src/androidTest/AndroidManifest.xml index a0c5e81e03..6c0e836668 100644 --- a/benchmark/src/androidTest/AndroidManifest.xml +++ b/benchmark/src/androidTest/AndroidManifest.xml @@ -14,4 +14,4 @@ tools:ignore="HardcodedDebugMode" tools:replace="android:debuggable" > - \ No newline at end of file + diff --git a/instrumentation/build.gradle b/instrumentation/build.gradle index f884cd9c8c..5f7d0026d8 100644 --- a/instrumentation/build.gradle +++ b/instrumentation/build.gradle @@ -53,4 +53,3 @@ android { } } } - diff --git a/integration/compose/src/main/AndroidManifest.xml b/integration/compose/src/main/AndroidManifest.xml index d6dd9b73a5..c4c4da7490 100644 --- a/integration/compose/src/main/AndroidManifest.xml +++ b/integration/compose/src/main/AndroidManifest.xml @@ -1,4 +1,4 @@ - \ No newline at end of file + diff --git a/integration/cronet/src/test/AndroidManifest.xml b/integration/cronet/src/test/AndroidManifest.xml index 8f379fcd1d..1cb457d16b 100644 --- a/integration/cronet/src/test/AndroidManifest.xml +++ b/integration/cronet/src/test/AndroidManifest.xml @@ -3,4 +3,3 @@ package="com.bumptech.glide.integration.cronet"> - diff --git a/integration/ktx/src/main/AndroidManifest.xml b/integration/ktx/src/main/AndroidManifest.xml index 1a4808764d..97fbcf926f 100644 --- a/integration/ktx/src/main/AndroidManifest.xml +++ b/integration/ktx/src/main/AndroidManifest.xml @@ -1,2 +1,2 @@ - \ No newline at end of file + diff --git a/integration/okhttp4/src/main/AndroidManifest.xml b/integration/okhttp4/src/main/AndroidManifest.xml index cebf302eef..0093fcb2ce 100644 --- a/integration/okhttp4/src/main/AndroidManifest.xml +++ b/integration/okhttp4/src/main/AndroidManifest.xml @@ -1,4 +1,4 @@ - \ No newline at end of file + diff --git a/integration/sqljournaldiskcache/src/main/AndroidManifest.xml b/integration/sqljournaldiskcache/src/main/AndroidManifest.xml index 3407c4b980..84c979f69e 100644 --- a/integration/sqljournaldiskcache/src/main/AndroidManifest.xml +++ b/integration/sqljournaldiskcache/src/main/AndroidManifest.xml @@ -1,4 +1,4 @@ - \ No newline at end of file + diff --git a/samples/imgur/build.gradle b/samples/imgur/build.gradle index 34a7056bd9..c8d165a80b 100644 --- a/samples/imgur/build.gradle +++ b/samples/imgur/build.gradle @@ -53,4 +53,3 @@ task run(type: Exec, dependsOn: 'installDebug') { description 'Installs the APK and runs the main activity: "gradlew :samples:???:run"' commandLine "${android.sdkDirectory}/platform-tools/adb", 'shell', 'am', 'start', '-n', 'com.bumptech.glide.samples.card/.MainActivity' } - diff --git a/samples/imgur/src/main/AndroidManifest.xml b/samples/imgur/src/main/AndroidManifest.xml index 3e3fa4c1fe..7487a65345 100644 --- a/samples/imgur/src/main/AndroidManifest.xml +++ b/samples/imgur/src/main/AndroidManifest.xml @@ -28,4 +28,4 @@ - \ No newline at end of file + From 87b7c403d96e457494f1662c2ecd9194c712d58a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=B3bert=20Papp=20=28TWiStErRob=29?= Date: Wed, 26 Jul 2023 13:42:24 +0100 Subject: [PATCH 6/7] Migrate - - + diff --git a/annotation/ksp/integrationtest/build.gradle b/annotation/ksp/integrationtest/build.gradle index 6b379e0a51..2454135cde 100644 --- a/annotation/ksp/integrationtest/build.gradle +++ b/annotation/ksp/integrationtest/build.gradle @@ -15,6 +15,7 @@ plugins { } android { + namespace 'com.bumptech.glide.annotation.ksp.integrationtest' compileSdkVersion libs.versions.compile.sdk.version.get() defaultConfig { diff --git a/annotation/ksp/integrationtest/src/main/AndroidManifest.xml b/annotation/ksp/integrationtest/src/main/AndroidManifest.xml index edf12fb1a5..8072ee00db 100644 --- a/annotation/ksp/integrationtest/src/main/AndroidManifest.xml +++ b/annotation/ksp/integrationtest/src/main/AndroidManifest.xml @@ -1,5 +1,2 @@ - - - + diff --git a/annotation/ksp/test/build.gradle b/annotation/ksp/test/build.gradle index 292dcd5b92..c305c65a60 100644 --- a/annotation/ksp/test/build.gradle +++ b/annotation/ksp/test/build.gradle @@ -4,6 +4,7 @@ plugins { } android { + namespace 'com.bumptech.glide.annotation.ksp.test' compileSdkVersion libs.versions.compile.sdk.version.get() defaultConfig { diff --git a/annotation/ksp/test/src/main/AndroidManifest.xml b/annotation/ksp/test/src/main/AndroidManifest.xml index 91d7cf5740..8072ee00db 100644 --- a/annotation/ksp/test/src/main/AndroidManifest.xml +++ b/annotation/ksp/test/src/main/AndroidManifest.xml @@ -1,5 +1,2 @@ - - + diff --git a/benchmark/build.gradle b/benchmark/build.gradle index fb9768b80f..65a8fb817f 100644 --- a/benchmark/build.gradle +++ b/benchmark/build.gradle @@ -4,6 +4,7 @@ plugins { } android { + namespace 'com.bumptech.glide.benchmark' compileSdkVersion libs.versions.compile.sdk.version.get() buildToolsVersion "30.0.3" diff --git a/benchmark/src/androidTest/AndroidManifest.xml b/benchmark/src/androidTest/AndroidManifest.xml index 6c0e836668..7795cfbe2e 100644 --- a/benchmark/src/androidTest/AndroidManifest.xml +++ b/benchmark/src/androidTest/AndroidManifest.xml @@ -1,7 +1,6 @@ + xmlns:tools="http://schemas.android.com/tools">