-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few tweaks: enable setting the host to bind to, and reduced access for some attributes #28
Conversation
BTW cc @smellsblue |
👍 though how about the bind have the tcp:// and port baked into the option rather than the host and port separate used to put it in? That way, if someone wants to bind it on a unix socket and wrap it in an nginx/apache server or something, it would be pretty easy. |
Yip, will do it |
Awesome! Looks good to me! Once you merge this in, I'll update documentation branch with the changes. |
Ah, cool, I'll just do it. |
Awesome. We can probably just pass through |
I don't think that would be a problem, this was just attacking the configuration system. I'll give it a spin later. |
I've been thinking about command line config for a while... I put my thoughts into #30. Also, the new bind option already is a pass through to Puma, should we also support host and port though? I ask because from the Puma project, it looks like the bind option is preferred over host and port. Digging into the code a bit, the command line options for Puma doesn't actually have a host option, and the port option acts effectively like the bind option behind the scenes. While there is no Thoughts @indirect, @pcarranza? |
I must have been thinking of the config DSL. It's fine with me to only support bind and port on the command line. |
Mainly because I am running gemstash in a host on with a public IP, I don't want it to be a public mirror.