-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add many ruby versions to travis configuration #31
Conversation
8b0c0ab
to
88d2143
Compare
I feel like this might be more versions than we need. I tried to find something that lists the officially supported versions, but all I could find was the downloads page and a blog post about the recent Ruby versioning change. Based on the versioning post, I think if we use |
If we pull in #33, I'd like to see |
I think that supporting the whole 2.x makes sense. Then with your change we can support older Ruby gems, but I'm not sure if we actually want to do that. Thoughts @indirect? |
I'd be happy to deal with any issues that crop up for legacy RubyGems support. I think it is worth it to maintain as much of a "it works out of the box" feel as possible. I updated #33 to isolate the legacy support to a single block of code that should be much clearer how to clean up when we want to drop support (I would say we should drop such legacy support once Ruby 2.1 is no longer supported, since earlier When you say whole of 2.x do you mean adding |
Teeny, not every patch as I understand that we are not doing anything too weird |
Just to make this clear. We should add then:
right? |
Yeah, but maybe |
Makes sense. |
7d09acf
to
2cab3c9
Compare
👍 |
To be sure that gemstash is supported in these ruby versions at least.
cc/ @smellsblue