Use Sequel::Model #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helper method read_gem for reading contents of test gem
… spec Disconnect DB and flush cache on private gemstash server specs, otherwise problems
Keep a single DB instance and use it everywhere Break out migration logic so specs can do it when deleting the database file Preserve environment when running setup_spec, otherwise it breaks other specs Clean the test path specs are run, otherwise past runs could affect the next run
Use forwardable in Gemstash::Cache Drop need for Gemstash::DB::Rubygem.find_id Thanks @pcarranza!
|
👍 I like it, smaller objects 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of
Gemstash::DBHelperand useSequel::Modelwith corresponding model classes instead.This is based off #36, so merging it will include both.