Build against JRuby #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smellsblue
force-pushed
the
build-against-jruby
branch
from
763efd9 to
7899c9a
Compare
Use jdbc when using JRuby Platform needs to be stringified when not Ruby Build JRuby on Travis, mostly to see if bundling works with Gemstash and JRuby In ExecHeleprs: Specify BUNDLE_GEMFILE when there is a Gemfile in the directory, otherwise JRuby bug gives us empty BUNDLE_GEMFILE, which triggers weird handling in Bundler to evaluate empty BUNDLE_GEMFILE incorrectly as the current directory (will be fixed in 1.11.0). Also hitting another bug that will be fixed in 1.11.0 where a warning is output when bundle exec on JRuby 9000 (affects integration spec output).
…stash is fetching the right gem Update specs to offer both versions, and assert the correct one is being used depending on the platform we are on
smellsblue
force-pushed
the
build-against-jruby
branch
from
7899c9a to
ebec3f0
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly about running the specs (especially integration specs) against JRuby to ensure Gemstash responds with the correct gems when you are using a different platform.
However, if we want to support a JRuby version of this gem, this PR includes support for that as well... it will just be a matter of building and pushing the gem under JRuby.
A few oddities I encountered:
JRuby 9000yet... hence thejruby-9.0.3.0version in.travis.yml. Anything else will not install the right version of JRubyProcess.spawnis broken under JRuby, I filed a ticket against JRuby for this, it affected us because it causes Bundler to think our Gemfile was the current working directoryJRuby 9000, I have this sectioned off in the helper so we can remove the code when Bundler gets updatedJRuby 9000in a weird way such that a separate warning message comes up (I don't see it running on my machine). I adapted the spec for this case like I did for the previous item, but I don't know when or how this might get fixed by Travis