Various fixes 2 #47
Merged
Various fixes 2 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test doesn't seem to really need random data, just arbitrary data After reading https://github.com/jruby/jruby/wiki/Improving-startup-time#ensure-your-system-has-adequate-entropy, I think we should avoid using SecureRandom except where we really need it
This along with --dev significantly improves spec duration with JRuby
Don't rely on current directory... it could include a relative path with a space, which could cause issues Use relative path to JRuby Bundler monkeypatch, so spaces won't cause a problem
This requires significantly more memory to run, but results in much faster builds
This and the previous commit fixes #46
| let(:resource_id) { SecureRandom.uuid } | ||
| let(:content) { SecureRandom.base64 } | ||
| let(:resource_id) { "42" } | ||
| let(:content) { "zapatito" } |
There was a problem hiding this comment.
😆
42 is a perfect randomly generated number!
|
Looks good, go for it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #42 and fixes #46, along with some random things I found along the way.