Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow log_file to be configured, default to server.log in base dir #74

Merged
merged 2 commits into from
Mar 14, 2016

Conversation

mrchucho
Copy link
Contributor

We deploy gemstash to our continuous delivery server and would like to have it log to something other than the default location. This small change adds support for a config option :log_file that overrides the default log file location.

@mrchucho
Copy link
Contributor Author

Hrm, seeing the same errors in Travis that I saw when trying to test locally. The errors don't appear to be related to my change, however.

@smellsblue
Copy link
Contributor

@mrchucho strangely enough, it might be the new specs... sometimes they leak into each other in weird ways... like a new database connection that causes failures because the DB is wrapped in a transaction. I've had to hack around this sort of thing before. I'll see if I can help out a little bit later today :-)

@smellsblue
Copy link
Contributor

@mrchucho nope, that's not it, I see the specs got added after the code, and it failed then too... I'll look closer later...

@smellsblue
Copy link
Contributor

OK, so I was running specs and everything was working fine... then I bundle updated and things started breaking... I suspect there is a gem that got updated and is breaking things...

@smellsblue smellsblue added this to the Version 1.1.0 milestone Feb 20, 2016
@pcarranza
Copy link
Contributor

Hey @mrchucho, I think that the specs got fixed in master, could you rebase this on top of master again please?

After that I think we are good to merge.

@mrchucho mrchucho force-pushed the configurable_log_file branch from fd8da4e to 304912b Compare March 14, 2016 13:36
@mrchucho
Copy link
Contributor Author

Rebased! Thanks!

pcarranza added a commit that referenced this pull request Mar 14, 2016
Allow log_file to be configured, default to server.log in base dir
@pcarranza pcarranza merged commit 292590a into rubygems:master Mar 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants