Gracefully handle empty configuration files #97
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if
~/.gemstash/config.yml
(or~/.gemstash/config.yml.erb
) exists but has no yaml content theYAML.load_file
method returnsnil
.This PR sets a default value of an empty hash, this is used in the case that the parsed config file is empty.
I also introduced a next test case for this.
I encountered this when using a dynamically generated
config.yml
that had no content (so defaults were expected).I also made a small change to the method, removing the variable assignment as the values are returned. and assigned to that variable in the callers.