-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update supported python versions (remove Python 3.7 Support) #1214
Comments
@lavigne958 added to 6.0.0 because I believe this is a "breaking change" that you often mention... |
I thought about it, I am not too sure yet. I think it is a breaking Change. 🧐 |
If Python 3.7 is removed from the workflow I think it is definitely breaking |
if we remove it from the classifier for tox then everyone using gpsread on python 3.7 won't be able to use it. We can:
|
not sure what you mean by "tox classifier", do you mean this? Lines 1 to 2 in 20a2209
This is the intention, no? For the 6.0.0 release at least, you will not be able to use Python 3.7. If you want to, you must specify gspread v5. |
sorry my mistake, I meant: the classifier in which is metadata for pypi to understand things like which version is compatible with this package. Yes agreed we wait for 6.0.0 to release without the python3.7 version that sounds good. new major version -> add breaking changes. |
done in d7e968a |
somehow we should remember to put this in the changelog? cannot remember if it is part of a PR or not, so if it will/won't show up automatically |
I don't know yet... we merged in 6.0.0, so we can't tell yet. |
Python 3.7 End of life is 2023-06-27
Here we can gather the things that must be done for removing Python 3.7 support.
The text was updated successfully, but these errors were encountered: