Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported python versions (remove Python 3.7 Support) #1214

Closed
6 tasks done
alifeee opened this issue Jun 8, 2023 · 9 comments
Closed
6 tasks done

Update supported python versions (remove Python 3.7 Support) #1214

alifeee opened this issue Jun 8, 2023 · 9 comments
Assignees
Milestone

Comments

@alifeee
Copy link
Collaborator

alifeee commented Jun 8, 2023

Python 3.7 End of life is 2023-06-27

Here we can gather the things that must be done for removing Python 3.7 support.

@alifeee alifeee added this to the 6.0.0 milestone Jun 8, 2023
@alifeee
Copy link
Collaborator Author

alifeee commented Jun 8, 2023

@lavigne958 added to 6.0.0 because I believe this is a "breaking change" that you often mention...

@lavigne958
Copy link
Collaborator

I thought about it, I am not too sure yet.

I think it is a breaking Change. 🧐

@alifeee
Copy link
Collaborator Author

alifeee commented Jun 8, 2023

If Python 3.7 is removed from the workflow I think it is definitely breaking

@alifeee alifeee mentioned this issue Jun 8, 2023
6 tasks
@lavigne958
Copy link
Collaborator

if we remove it from the classifier for tox then everyone using gpsread on python 3.7 won't be able to use it.

We can:

  1. add a deprecated warning if using python3.7
  2. remove it right after that from our workflow (that will release the dependency PRs)
  3. update the classifier later (in some versions in the future)
    What do you think ?

@alifeee
Copy link
Collaborator Author

alifeee commented Jun 14, 2023

not sure what you mean by "tox classifier", do you mean this?

gspread/tox.ini

Lines 1 to 2 in 20a2209

[tox]
envlist = py36,py37,py38,py39

everyone using gpsread on python 3.7 won't be able to use it.

This is the intention, no? For the 6.0.0 release at least, you will not be able to use Python 3.7. If you want to, you must specify gspread v5.

@lavigne958
Copy link
Collaborator

lavigne958 commented Jun 14, 2023

not sure what you mean by "tox classifier", do you mean this?

gspread/tox.ini

Lines 1 to 2 in 20a2209

[tox]
envlist = py36,py37,py38,py39

everyone using gpsread on python 3.7 won't be able to use it.

This is the intention, no? For the 6.0.0 release at least, you will not be able to use Python 3.7. If you want to, you must specify gspread v5.

sorry my mistake, I meant: the classifier in setup.py

which is metadata for pypi to understand things like which version is compatible with this package.

Yes agreed we wait for 6.0.0 to release without the python3.7 version that sounds good. new major version -> add breaking changes.

@alifeee
Copy link
Collaborator Author

alifeee commented Jun 29, 2023

bump sphinx to latest version

done in d7e968a

@alifeee alifeee closed this as completed Jun 29, 2023
@alifeee
Copy link
Collaborator Author

alifeee commented Jun 29, 2023

somehow we should remember to put this in the changelog?

cannot remember if it is part of a PR or not, so if it will/won't show up automatically

@lavigne958
Copy link
Collaborator

I don't know yet... we merged in 6.0.0, so we can't tell yet.
We'll see when we merge 6.0.0 into master branch 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants