Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecation warning for colors changing from dict -> hex #1272

Closed
alifeee opened this issue Aug 15, 2023 · 1 comment · Fixed by #1278
Closed

Add deprecation warning for colors changing from dict -> hex #1272

alifeee opened this issue Aug 15, 2023 · 1 comment · Fixed by #1278
Assignees
@alifeee
Milestone
5.11.0

Comments

@alifeee
Copy link
Collaborator

alifeee commented Aug 15, 2023

See #1270

Can this be done in a way where users can change their code to remove the deprecation warnings? Like in #1264

I'm not sure
@alifeee alifeee added this to the 5.11.0 milestone Aug 15, 2023
@alifeee alifeee mentioned this issue Aug 16, 2023
Merged
@lavigne958
Copy link
Collaborator

Not really, unless we add both methods I don't think so.
We provide a method for users to convert the original dict value to hex so they have a direct way to convert the code they have. But it can't be transparent 🙄

@alifeee alifeee mentioned this issue Aug 17, 2023
Merged
@alifeee alifeee self-assigned this Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alifeee alifeee

Labels
None yet
Projects
None yet
Milestone
5.11.0
Development

Successfully merging a pull request may close this issue.

Add deprecation warnings for colors burnash/gspread
2 participants
@alifeee @lavigne958