Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set maintain_size to True by default #1306

Closed
alifeee opened this issue Sep 28, 2023 · 3 comments
Closed

Set maintain_size to True by default #1306

alifeee opened this issue Sep 28, 2023 · 3 comments
Assignees
Labels
Improvement Need investigation This issue needs to be tested or investigated
Milestone

Comments

@alifeee
Copy link
Collaborator

alifeee commented Sep 28, 2023

This behaviour should be default, as discussed in.

#1289

However, this is a breaking change - so should be added at the next major release (6.0.0)

@alifeee alifeee added this to the 6.0.0 milestone Sep 28, 2023
@alifeee alifeee self-assigned this Sep 28, 2023
@alifeee
Copy link
Collaborator Author

alifeee commented Sep 28, 2023

(since get is one of the most used methods, this "breaking change" should be carefully considered)

@alifeee alifeee added the Need investigation This issue needs to be tested or investigated label Oct 28, 2023
@alifeee
Copy link
Collaborator Author

alifeee commented Nov 14, 2023

@lavigne958 this is the final issue left in 6.0.0

it requires thought.

For now, I suggest we leave it as False, so it works the same way as before, for maximum backwards compatibility,, and close this issue with no change. What do you think?

@lavigne958
Copy link
Collaborator

Agreed let's leave it like this for now.

@alifeee alifeee closed this as not planned Won't fix, can't repro, duplicate, stale Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Need investigation This issue needs to be tested or investigated
Projects
None yet
Development

No branches or pull requests

2 participants