Remove unused parameter or use it

[lavigne958]

Overview

I noticed the following unused parameter, we should either use it, or remove it.

gspread/gspread/worksheet.py

Line 574 in f6d1b1b

use_index=0,

I'll have a look at the code itself a bit longer to check what is best.

[alifeee]

Hi. use_index was added by #1301 (see #1301 (comment)). Currently, it does nothing if not set to use_index=0

gspread/gspread/worksheet.py

Lines 643 to 646 in f6d1b1b

	if use_index not in [0, 1]:
	raise ValueError("use_index must be either 0 or 1")
	if use_index == 1: # TODO: implement use_index=1
	raise NotImplementedError("use_index=1 is not implemented yet")

It exists so that #808 can be implemented. If use_index = 1 were used, then we could get records using the first column as headers, instead of the first row.

[lavigne958]

alright so for now:

• it has no impact
• if a user set it to the wrong value it will raise an exception and stop the program
• we don't plan to use it so far

so let's remove it. it's nothing big we can add it back later when we need.

I suggest.

[alifeee]

agreed. made a PR