Fixed IndexError in Worksheet.get_all_records() #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added data len checking to prevernt IndexError (issue burnash#629)
Added data length checking to prevent IndexError in .get_all_records() method of Worksheet class. This is a small fix for the issue burnash#629.
|
I don't know why the Travis CI fails, but I think this is due to some other code and tests which aren't related to my code changes because it works on my machine well and the bug is fixed :) |
|
Thank you for the contribution. Please ignore Travis failure, it uses recorded data and there's an unrelated issue with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added data length checking to prevent
// Sorry for the second similar pull requestIndexErrorin.get_all_records()method ofWorksheetclass. This is a small fix for the issue #629.