Issue #687 : Add feature to set position of worksheet #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@burnash please have a look. |
|
This is a good change to make. Would be interested in seeing this be merged! |
lucasklaassen
suggested changes
Nov 17, 2019
gspread/models.py
Outdated
| @@ -269,6 +271,9 @@ def add_worksheet(self, title, rows, cols): | |||
| }] | |||
| } | |||
|
|
|||
| if index: | |||
There was a problem hiding this comment.
Suggested change
| if index: | |
| if index is not None: |
If index is set to 0, this will return false and not send the index to google. Setting an index of 0 is very useful when you want your current worksheet to be the first worksheet within the spreadsheet.
|
@lucasklaassen thanks for the review, I will update my PR as soon as possible |
Solves issue burnash#687. Added param index in add_worksheet method to set index of the newly created worksheet
|
@lucasklaassen done with the change you suggested. |
|
@burnash this change is valuable and the code looks good. Can you please review and merge? |
|
@djmgit thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #687. Added param index in add_worksheet method
to set index of the newly created worksheet