-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore Numericising Specific Columns in get_all_records #701
Conversation
Allows passing in a list of column indices (1-indexed) to avoid numericising them in the get_all_records method, also allows for the special case ['all'] to avoid numericising all columns.
@benjamindhimes Thank you very much for your contribution. I'm really sorry for the late response and I appreciate your persistence. I'll review the PR shortly. |
…nd partial function.
Works well. Thank you very much! Kudos for expanding the docstring for |
Hello friends! How can I use this fix in my code? I'm using gspread for python3 and I really need the leading zeros and get_all_records() is removing it |
Just to answer my own question and to help others that may have the same problem. Now you can keep leading zeros just using get_all_records() like this: get_all_records(numericise_ignore=['all']) and gspread won't convert your strings! Thank so much for this @benjamindhimes !!! You are awesome! |
@mmsbr I was looking for the solving of a problem for a couple of days but it was so easy. I should read the fu***** documentation and code of the module. Thank you very much for the solution! |
Allows passing in a list of column indices (1-indexed) to avoid numericising them in the get_all_records method, also allows for the special case ['all'] to avoid numericising all columns. Fixes #581, #568, #231 Improvement over my previously-closed PR of #598.