-
-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
w3.org states elements with role='gridcell'
should be owned by an element with role='row'
#217
Comments
Grouping grid cells into rows is not something I'm interested in doing. Adding the overhead of additional DOM element wrappers to performance sensitive areas like grid doesn't feel like a worthwhile tradeoff. Is there a different aria role that would be better suited to the current DOM structure? |
Unfortunately not, I've definitely got a grid of data to present and according to that spec, elements with role |
I can second that this is an issue for my team. The only way I know how to fulfill this requirement now is using I have an idea I'm not yet happy with that explores exposing a rendering mechanism for such purposes. It solves accessibility challenges, but it only partially enables sticky row / column handling, which I sort of feel like is in the same category as this (i.e. cell decoration and grouping). I also am sympathetic to not wanting to expose too much of the inner workings to prevent the API from getting cluttered. But I'm very interested in this particular issue's resolution. I don't want to be pedantic, but the language in the spec that @MarkFalconbridge linked to is actually a little more forceful (emphasis not added):
Beyond just wrapping things with a Happy to help on this one, if you find a solution but don't find the time, @bvaugh. |
Realistically, I don't think I'll invest time in this issue any time soon. I may even prefer to remove the current role entirely rather than add wrapping layers. I think a lot of existing advanced usage of |
Definitely respect the zero sum game of open source time management. Would you be interested in PRs that are:
|
I'd love to review ideas, yes. Can't promise to land them, but it would be helpful for discussion.
|
Wondering if #218 has any plans to happen. Lacking screen reader accessibility is totally a deal-breaker for me and my company. Sad that we invested some time with this library to realize this is not possible to be used in a production environment where accessibility is required. Maybe adding a note on the readme file would help to be aware of the lack of accessibility support for this specific scenario? I think for this specific case https://bvaughn.github.io/react-virtualized/#/components/Table is a solid alternative. By the way, thank you for the amazing work @bvaughn |
https://www.w3.org/TR/wai-aria-1.1/#grid states that elements with
role='gridcell'
should be owned by an element withrole='row'
.With the current implementation of
FixedSizedGrid
orVariableSizedGrid
I don't think this is possible as there aren't any elements surrounding a row of cells once rendered in the DOM.Is this something that could be added so that full aria support becomes possible?
The text was updated successfully, but these errors were encountered: