Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Azure Cloudshell #6

Merged
merged 3 commits into from
Feb 21, 2022
Merged

Conversation

Hekku2
Copy link
Contributor

@Hekku2 Hekku2 commented Feb 21, 2022

Azure Cloudshell-container should now work for this, so we don't need to install Az-module separately anymore.

@Hekku2 Hekku2 marked this pull request as ready for review February 21, 2022 10:53
@Hekku2 Hekku2 requested a review from savpek February 21, 2022 11:26
@@ -1,4 +1,4 @@
FROM mcr.microsoft.com/powershell:7.1.0-alpine-3.12-20201116
FROM mcr.microsoft.com/azure-cloudshell@sha256:075eadba1d78d537fa188fe82d4bc0f6e552ab3416d60c0b43bff5fd5372535e
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is strange decision on cloud-shell side not to publish versioned containers even after fact that they have versioned releases 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it was kind of strange that they didn't even seem to have a page in dockerhub. I have this feeling that we are doing something wrong here. :D

@Hekku2 Hekku2 merged commit bf8bdae into master Feb 21, 2022
@Hekku2 Hekku2 deleted the feature/migrate-to-cloudshell branch February 21, 2022 11:34
@Hekku2 Hekku2 linked an issue Feb 21, 2022 that may be closed by this pull request
This was referenced Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding support for bicep
2 participants