Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the windows-sys dependency #591

Closed
notgull opened this issue Apr 3, 2023 · 4 comments
Closed

Remove the windows-sys dependency #591

notgull opened this issue Apr 3, 2023 · 4 comments

Comments

@notgull
Copy link
Contributor

notgull commented Apr 3, 2023

The windows-sys crate has gone through quite a bit of version churn, see microsoft/windows-rs#1720. Therefore, some of the foundational crates in the ecosystem have been manually creating Win32 bindings for what they need. rustix may want to migrate in this direction as well.

@notgull
Copy link
Contributor Author

notgull commented Apr 3, 2023

See here for an example of how this might be done.

@sunfishcode
Copy link
Member

I've seen Amanieu/parking_lot#374 which seems to contain the main rationale for this, and I'm surprised that there seems to be an absence of any kind of numbers describing how much compile time this saves, or even how much filesystem cache space or network traffic it saves or anything else. I'm not eager to take on new kinds of complexity to solve an abstract problem.

@Jake-Shadle
Copy link

I plan on elucidating all of this in a blog post soon, parking_lot was simply the first crate I chose while iterating on a generation tool since it is foundational and thus has an outsize ecosystem effect, and was also just low hanging fruit that I was fairly confident would be merged.

@notgull
Copy link
Contributor Author

notgull commented May 6, 2023

Closing for now.

@notgull notgull closed this as not planned Won't fix, can't repro, duplicate, stale May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants