Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cranelift-module: Support marking data object as read-only C string #8901

Open
bjorn3 opened this issue Jul 4, 2024 · 0 comments
Open

cranelift-module: Support marking data object as read-only C string #8901

bjorn3 opened this issue Jul 4, 2024 · 0 comments

Comments

@bjorn3
Copy link
Contributor

bjorn3 commented Jul 4, 2024

Feature

See title

Benefit

This would allow the linker to deduplicate the strings. In addition some linker don't like mixing attributes between sections that get merged, so if the user of cg_clif specified that the data object needs to end up in __TEXT/__cstring, we will need to respect the cstring_literals section type likely specified by the user too.

Implementation

cranelift-jit can ignore this and cranelift-object can use SectionKind::ReadOnlyString.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant