Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Department class to read from JSON file #50

Open
mswindler opened this issue Aug 21, 2019 · 1 comment
Open

Convert Department class to read from JSON file #50

mswindler opened this issue Aug 21, 2019 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers priority: low

Comments

@mswindler
Copy link
Collaborator

No description provided.

@mswindler mswindler added enhancement New feature or request good first issue Good for newcomers priority: low labels Aug 21, 2019
@mswindler
Copy link
Collaborator Author

Currently Department is basically an enumerated class:

class Department:

Which isn't the greatest practice unless it is done correctly, and using an empty class with a bunch of constants isn't the right practice in Python.

Eventually we'll want to take a look at how we handle departments entirely, and make them more robust (i.e. when publishing to a department, exporting, etc.), but there are a few departments that we must keep:

Maya Departments:

  • model

  • anim

  • rig

  • layout

Houdini departments:

  • modify

  • material

  • hair

  • cloth

Other useful departments:

  • texture (for storing texture maps)

  • render (for storing the rendered frames for a shot)

Departments we should consider re-designing:

  • hda: hda should only exist for tools, and if we have a directory separate from assets for tools (which we do) then why have departments when hda would be the only department?

  • cycles

  • cfx

  • comp: Composited shots should be stored in the rendered_shots project directory.

  • assembly: since assemble and clone are now handled in a very similar way, I don't know why we need assembly as a department.

Game plan:

So what we'd want to do is keep the departments we need as the default available departments in a project JSON file. Each grouping of departments should be in list format in the JSON file.

Then, Department should have it's own file (first of all) and the class methods should deal with reading and writing to that JSON file to get and add departments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers priority: low
Projects
None yet
Development

No branches or pull requests

1 participant