Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log workflow info also when visibility data goes to DLQ #3138

Merged
merged 9 commits into from
Mar 27, 2020
Merged

Log workflow info also when visibility data goes to DLQ #3138

merged 9 commits into from
Mar 27, 2020

Conversation

mkolodezny
Copy link
Contributor

What changed?
Log workflow info also when visibility data goes to DLQ

Why?
We need those tags to filter messages which are going to DLQ (failed to be handled by Kafka consumer )

How did you test it?
unit tests

Potential risks
messages wont be delivered into DLQ

@mkolodezny mkolodezny requested a review from vancexu March 25, 2020 19:33
@mkolodezny mkolodezny self-assigned this Mar 25, 2020
@CLAassistant
Copy link

CLAassistant commented Mar 25, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mkolodezny mkolodezny linked an issue Mar 25, 2020 that may be closed by this pull request
Log workflow info also when visibility data goes to DLQ #3060
Closed
yycptt
yycptt reviewed Mar 25, 2020
View reviewed changes
service/worker/indexer/esProcessor.go Outdated Show resolved Hide resolved
service/worker/indexer/esProcessor.go Show resolved Hide resolved
service/worker/indexer/esProcessor.go Outdated Show resolved Hide resolved
vancexu
vancexu reviewed Mar 25, 2020
View reviewed changes
service/worker/indexer/esProcessor.go Outdated Show resolved Hide resolved
service/worker/indexer/esProcessor.go Outdated Show resolved Hide resolved
service/worker/indexer/esProcessor.go Outdated Show resolved Hide resolved
service/worker/indexer/esProcessor.go Outdated Show resolved Hide resolved
vancexu
vancexu reviewed Mar 26, 2020
View reviewed changes
service/worker/indexer/esProcessor.go Outdated Show resolved Hide resolved
service/worker/indexer/esProcessor_test.go Outdated Show resolved Hide resolved
service/worker/indexer/esProcessor.go Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Mar 26, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 67.148% when pulling 0961c1d on log_info_dlq into 9b46c2e on master.

venkat1109
venkat1109 reviewed Mar 26, 2020
View reviewed changes
Copy link
Contributor

@venkat1109 venkat1109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments primarily on style.

service/worker/indexer/esProcessor.go Outdated Show resolved Hide resolved
service/worker/indexer/esProcessor.go Outdated Show resolved Hide resolved
service/worker/indexer/esProcessor.go Outdated Show resolved Hide resolved
service/worker/indexer/esProcessor_test.go Show resolved Hide resolved
@venkat1109 venkat1109 requested a review from a team March 26, 2020 23:20
@mkolodezny mkolodezny merged commit a933ae0 into master Mar 27, 2020
@mkolodezny mkolodezny deleted the log_info_dlq branch March 27, 2020 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vancexu vancexu vancexu approved these changes

@venkat1109 venkat1109 venkat1109 left review comments

@yycptt yycptt yycptt approved these changes

Assignees

@mkolodezny mkolodezny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Log workflow info also when visibility data goes to DLQ
6 participants
@mkolodezny @CLAassistant @coveralls @venkat1109 @vancexu @yycptt