Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move NDC related code to ndc package #3213

Merged
merged 8 commits into from
Apr 24, 2020
Merged

Move NDC related code to ndc package #3213

merged 8 commits into from
Apr 24, 2020

Conversation

yux0
Copy link
Contributor

@yux0 yux0 commented Apr 23, 2020 •
edited
Loading

What changed?
Move NDC related code to ndc package

Why?
Refactor

How did you test it?
existing unit test and integration tests

Potential risks
cross DC replication fails

@yux0 yux0 requested review from yycptt and a team April 23, 2020 06:15
@coveralls
Copy link

coveralls commented Apr 23, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 68.306% when pulling 22aaf82 on ndc_package into 3b88ac6 on master.

yycptt
yycptt reviewed Apr 23, 2020
View reviewed changes
service/history/constants/test_constants.go Show resolved Hide resolved
service/history/execution/workflowExecutionUtil.go Outdated Show resolved Hide resolved
service/history/reset/resetter.go Outdated Show resolved Hide resolved
service/history/workflowResetor_test.go Outdated Show resolved Hide resolved
service/history/errors/errors.go Outdated Show resolved Hide resolved
yycptt
yycptt approved these changes Apr 23, 2020
View reviewed changes
service/history/constants/test_constants.go Outdated Show resolved Hide resolved
@yux0 yux0 merged commit d6cbc1a into master Apr 24, 2020
@yux0 yux0 deleted the ndc_package branch April 24, 2020 00:05
@yycptt
Copy link
Contributor

yycptt commented Apr 24, 2020

#3181

mkolodezny pushed a commit to mkolodezny/cadence that referenced this pull request May 1, 2020
@yux0 @mkolodezny
Move NDC related code to ndc package (cadence-workflow#3213)
698816b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yycptt yycptt yycptt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yux0 @coveralls @yycptt