Add iterators and writers for persistence and blobstore for scanner workflow #3234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewjdawson2016
changed the title
emrahs
approved these changes
May 5, 2020
yux0
reviewed
May 5, 2020
| // TODO: check with Yu that this is correct | ||
| branchToken := e.ExecutionInfo.BranchToken | ||
| if e.VersionHistories != nil { | ||
| branchToken = e.VersionHistories.Histories[e.VersionHistories.CurrentVersionHistoryIndex].BranchToken |
There was a problem hiding this comment.
nit: I think you may do versionHistories.GetCurrentVersionHistory().BranchToken
yycptt
reviewed
May 5, 2020
andrewjdawson2016
force-pushed
the
WriterAndIterator
branch
from
f58f964 to
68dbb6e
Compare
mkolodezny
pushed a commit
to mkolodezny/cadence
that referenced
this pull request
May 11, 2020
yux0
pushed a commit
to yux0/cadence
that referenced
this pull request
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
These iterators and writes will be used in scanner and fixer workflow.
There are unit tests for generic write and iterator but I will write more for the concrete impls.