Fix reset reapply #3252
Merged
Fix reset reapply #3252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
reviewed
May 11, 2020
service/history/historyEngine.go
Outdated
| executionInfo := mutableState.GetExecutionInfo() | ||
| maxAllowedSignals := e.config.MaximumSignalsPerExecution(domainEntry.GetInfo().Name) | ||
| if maxAllowedSignals > 0 && (int(executionInfo.SignalCount)+len(toReapplyEvents)) >= maxAllowedSignals { | ||
| e.logger.Info("Execution limit reached for maximum signals during signal re-application", |
There was a problem hiding this comment.
This seems like a quite critical error, as it's non-retryable and the passive side doesn't even know the reapply has failed. Shall we use Error level log and probably emit some metrics?
There was a problem hiding this comment.
signal reapplication should ignore this limit.
or at least return error
There was a problem hiding this comment.
Remove this check in this PR. If it returns an error, the caller side has. to handle this error or it will retry forever. I will include it in a different PR.
wxing1292
reviewed
May 12, 2020
yycptt
approved these changes
May 12, 2020
yux0
added a commit
that referenced
this pull request
May 12, 2020
yux0
added a commit
to yux0/cadence
that referenced
this pull request
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
This is to fix the feedback loop on reset and re-apply
How did you test it?
Local test
Potential risks
This feedback loop issue is not fixed and causes backlog in replication stack