Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Priority Task Processor Improvements #3284

Merged
merged 3 commits into from
May 27, 2020

Conversation

yycptt
Copy link
Contributor

@yycptt yycptt commented May 27, 2020

What changed?

  1. Fix nil pointer exception when changing dynamic config for enabling priority task processor. This only happens when a shard is reloaded after the config is changed but before the host got restart.
  2. Update task processing retry policy to have a max attempts of 3 before putting into redispatch queue. This is for preventing standby tasks from occupying a worker goroutine for too long. For active tasks, in most cases the task will be completed before its third attempt.
  3. Update the logic for task priority assignment. Idea is to assign high priority to no-op tasks (tasks for standby domain submitted by active processor or vice versa) so that they won't get a low priority and block the ack level (especially for active processor) from advancing.

Why?
Bug fix and performance improvements.

How did you test it?
Unit test. Local canary.

Potential risks
N/A, feature flag disabled

@yycptt yycptt requested a review from yux0 May 27, 2020 00:47
@coveralls
Copy link

coveralls commented May 27, 2020

Coverage Status

Coverage increased (+0.05%) to 68.398% when pulling 4948fdc on yycptt:improve-priority-processor into da4cffa on uber:master.

@yycptt yycptt merged commit 34bac76 into cadence-workflow:master May 27, 2020
@yycptt yycptt deleted the improve-priority-processor branch May 27, 2020 05:40
yycptt added a commit that referenced this pull request May 27, 2020
mkolodezny pushed a commit to mkolodezny/cadence that referenced this pull request May 29, 2020
yux0 pushed a commit to yux0/cadence that referenced this pull request May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants