Remove -i go build flag (#3128) #3335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having -i go build flag tries to install target dependencies, which on some systems can result in permission denied errors. After some research it appears that this flag could had been used for improving build performance but this is no longer nessesary after Go 1.10. https://golang.org/doc/go1.10#build There is an outstanding go issue golang/go#27285 that is possibly related permission errors seen by some users. The advise there is to not use -i flag.
vancexu
approved these changes
Jun 12, 2020
yycptt
approved these changes
Jun 12, 2020
yux0
pushed a commit
to yux0/cadence
that referenced
this pull request
May 4, 2021
Having -i go build flag tries to install target dependencies, which on some systems can result in permission denied errors. After some research it appears that this flag could had been used for improving build performance but this is no longer nessesary after Go 1.10. https://golang.org/doc/go1.10#build There is an outstanding go issue golang/go#27285 that is possibly related permission errors seen by some users. The advise there is to not use -i flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Removed -i go build flag in Makefile
Why?
Having -i go build flag tries to install target dependencies,
which on some systems can result in permission denied errors.
After some research it appears that this flag could had been used for
improving build performance but this is no longer necessary after Go 1.10.
https://golang.org/doc/go1.10#build
There is an outstanding go issue golang/go#27285
that is possibly related permission errors seen by some users.
The advise there is to not use -i flag.
How did you test it?
Successful build.
Potential risks
This only affect build process. Worst case - not being able to build it.