Update replication path to use lazy retry on service busy error #3376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
reviewed
Jul 9, 2020
yycptt
approved these changes
Jul 9, 2020
yux0
added a commit
that referenced
this pull request
Jul 9, 2020
yux0
added a commit
to yux0/cadence
that referenced
this pull request
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Treat service busy error in the replication path with special retry policy. The retry policy is to slow down the replication
Why?
When replication receives service busy error, the error is from the persistence layer. If the persistence is too busy. We should slow down the replication to give the quota to active tasks.
How did you test it?
local
Potential risks
The replication could build up backlog when it slows down