Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add admin list domain command #3472

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Add admin list domain command #3472

merged 1 commit into from
Aug 24, 2020

Conversation

yycptt
Copy link
Contributor

@yycptt yycptt commented Aug 24, 2020

What changed?
Add admin command for listing domains.

➜  cadence  ./cadence adm d l --ps 2 --all     
       NAME      |                 UUID                 | DOMAIN DATA |   STATUS   | IS GLOBAL DOMAIN | ACTIVE CLUSTER  
  cadence-canary | b9e0c539-2a1f-4990-b796-fd4e37e8dcd3 |             | REGISTERED | false            | active          
  cadence-system | 32049b68-7872-4094-8e63-d0dd59896a83 |             | REGISTERED | false            | active          
Press Enter to show next page, press any other key then Enter to quit: 
           NAME          |                 UUID                 |  DOMAIN DATA   |   STATUS   | IS GLOBAL DOMAIN | ACTIVE CLUSTER  
  canary-archival-domain | 2d5d4e84-850e-4193-ab53-d432ab6a3697 |                | REGISTERED | false            | active          
  samples-domain         | 6ee4e39e-41a1-4cc9-bd5d-9c575e09d807 | k1: v2, k2: v2 | REGISTERED | false            | active

Why?
#3392

How did you test it?
Tested locally

Potential risks
N/A. Only CLI code is changed

@yycptt yycptt requested review from vancexu and yux0 August 24, 2020 17:42
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 66.872% when pulling 17a02ea on yycptt:list-domain-cmd into acb6b62 on uber:master.

vancexu
vancexu approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@vancexu vancexu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@yycptt yycptt merged commit 5535d29 into cadence-workflow:master Aug 24, 2020
@yycptt yycptt deleted the list-domain-cmd branch August 24, 2020 19:20
mkolodezny pushed a commit to mkolodezny/cadence that referenced this pull request Aug 27, 2020
@yycptt @mkolodezny
Add admin list domain command (cadence-workflow#3472)
0e62686
@yycptt yycptt mentioned this pull request Sep 16, 2020
Closed
yux0 pushed a commit to yux0/cadence that referenced this pull request May 4, 2021
@yycptt @yux0
Add admin list domain command (cadence-workflow#3472)
331305d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vancexu vancexu vancexu approved these changes

@yux0 yux0 Awaiting requested review from yux0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yycptt @coveralls @vancexu