Reduce log verbosity and add message to logs that didn't have one #3478
Conversation
| t.logger.Info("Timer queue processor state changed", tag.LifeCycleStarting) | ||
| defer t.logger.Info("Timer queue processor state changed", tag.LifeCycleStarted) |
There was a problem hiding this comment.
I think in most cases we use empty log message because the logger is already tagged with component tag which we can use for searching.
Is the idea here to provide an easier way to find all types of life cycle change events for a certain component?
There was a problem hiding this comment.
Exactly. I realized that the intent was to rely on the tag, but there are several types of logs with the same lifecycle event tag values although they are unrelated and it is cumbersome to narrow down the logs to a specific component.
The message field is one of the most frequently used fields to filter logs during an investigation, and I don't think it's a good experience to have a good chunk of logs that have the same message (null) even though they are unrelated.
What changed?
Changed Info logs with high volume and low value to Debug level and added a message to logs that didn't have a message.
Why?
Better use of logging pipeline and reducing the noise, and making lifecycle event logs more searchable.
How did you test it?
Existing unit and integration tests should be sufficient
Potential risks
None