Fix indexer to filter out invalid msg #3479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yux0
approved these changes
Aug 26, 2020
mkolodezny
approved these changes
Aug 26, 2020
vancexu
added a commit
that referenced
this pull request
Aug 26, 2020
mkolodezny
pushed a commit
to mkolodezny/cadence
that referenced
this pull request
Aug 27, 2020
yux0
pushed a commit
to yux0/cadence
that referenced
this pull request
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fix indexer to filter out invalid msg
Why?
ES has a limit of 512 for docID size. Cadence use wid~rid as docID for visibility in ES, but currently do not have limit on wid size.
For users who use advanced visibility on ES, this PR will filter out those workflow with wid too long.
Team is also considering a breaking change to limit wid in near future.
How did you test it?
local and staging tests
Potential risks
For user who use advanced visibility on ES, if the wid+rid is longer than 512, it will not be searchable because of this change.