Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split reconciliation/common #3513

Merged
merged 6 commits into from
Sep 17, 2020
Merged

Split reconciliation/common #3513

merged 6 commits into from
Sep 17, 2020

Conversation

mantas-sidlauskas
Copy link
Contributor

@mantas-sidlauskas mantas-sidlauskas commented Sep 14, 2020 •
edited
Loading

What changed?

  • Package reconciliation/common is now split to multiple packages.
  • Scan type is not passed as an argument to iterators/invariant manager
  • Blobstore iterator can deserialise to interface, no deserialisation helpers needed

Why?
These changes allows to reduce scope for changes when adding a new type of scanner.

How did you test it?
Unit test

Potential risks

@mantas-sidlauskas mantas-sidlauskas changed the title Split common Split reconciliation/common Sep 14, 2020
@coveralls
Copy link

coveralls commented Sep 14, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.06%) to 67.026% when pulling 68013dc on mantas-sidlauskas:split_common into 7223ddf on uber:master.

andrewjdawson2016
andrewjdawson2016 approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@andrewjdawson2016 andrewjdawson2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This refactor looks good to me.

@mantas-sidlauskas mantas-sidlauskas merged commit a054dbe into cadence-workflow:master Sep 17, 2020
@mantas-sidlauskas mantas-sidlauskas deleted the split_common branch September 17, 2020 06:14
yux0 pushed a commit to yux0/cadence that referenced this pull request May 4, 2021
@mantas-sidlauskas @yux0
Split reconciliation/common (cadence-workflow#3513)
c6e0af9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewjdawson2016 andrewjdawson2016 andrewjdawson2016 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mantas-sidlauskas @coveralls @andrewjdawson2016