Enforce persistence context timeout in application layer: Part 3 #3631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yux0
approved these changes
Oct 12, 2020
github-actions bot
pushed a commit
to vytautas-karpavicius/cadence
that referenced
this pull request
Feb 4, 2021
…ence-workflow#3631) Enforce persistence context timeout in shard context, execution context and execution cache Note context timeout errors in some shard context methods may result in rangeID change and shard movement. To minimize the impact, all persistence APIs for renew shard rangeID will still use context.Background(), and a minimal context timeout (1s) will be enforced on shard context methods that may lead to shard movement.
yux0
pushed a commit
to yux0/cadence
that referenced
this pull request
May 4, 2021
…ence-workflow#3631) Enforce persistence context timeout in shard context, execution context and execution cache Note context timeout errors in some shard context methods may result in rangeID change and shard movement. To minimize the impact, all persistence APIs for renew shard rangeID will still use context.Background(), and a minimal context timeout (1s) will be enforced on shard context methods that may lead to shard movement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Enforce persistence context timeout in shard context, execution context and execution cache
Context.Background() is used in unit tests if the test is not testing timeout case.
Why?
#3519
How did you test it?
Integration test.
Potential risks
May result in more persistence context timeout, rangeID change more frequently and more shard movement when persistence latency is high.