Fix if the replication state is nil #3645
Merged
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
force-pushed
the
fix_replication_state
branch
from
741c0d7 to
f0aa81f
Compare
mkolodezny
reviewed
Oct 14, 2020
| @@ -1684,12 +1684,16 @@ func (d *cassandraPersistence) GetCurrentExecution( | |||
| currentRunID := result["current_run_id"].(gocql.UUID).String() | |||
| executionInfo := createWorkflowExecutionInfo(result["execution"].(map[string]interface{})) | |||
| replicationState := createReplicationState(result["replication_state"].(map[string]interface{})) | |||
| lastWriteVersion := common.EmptyVersion | |||
| if replicationState != nil { | |||
There was a problem hiding this comment.
was it not supposed to be nil at all times?
There was a problem hiding this comment.
With the current logic, we still write into replication state
mkolodezny
approved these changes
Oct 14, 2020
yycptt
pushed a commit
that referenced
this pull request
Oct 15, 2020
github-actions bot
pushed a commit
to vytautas-karpavicius/cadence
that referenced
this pull request
Feb 4, 2021
yux0
added a commit
to yux0/cadence
that referenced
this pull request
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fix if the replication state is nil
Why?
NPE
How did you test it?
Potential risks