Separate thrift handler for matching service #3647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewjdawson2016
approved these changes
Oct 17, 2020
github-actions bot
pushed a commit
to vytautas-karpavicius/cadence
that referenced
this pull request
Feb 4, 2021
This is purely a mechanical refactoring that introduces additional ThriftHandler wrapper. For now it only forwards request to the original handler. Later on this will become a point for conversion between internal types and thrift types. Underlying handler will be independent of rpc protocol types. -Created Handler interface for matching service -Previous Handler struct renamed to HandlerImpl -Created ThriftHandler wrapper on top of Handler interface. At this point it only forward requests as is to underlying handler. -Created Mock for Handler interface. -Covered ThriftHandler with units tests. Test that requests are forwarded to underlying handler and response is returned as is. -Replaced handler registration. Instead of registering HandlerImpl directly, wrap it with ThriftHandler and register it instead.
yux0
pushed a commit
to yux0/cadence
that referenced
this pull request
May 4, 2021
This is purely a mechanical refactoring that introduces additional ThriftHandler wrapper. For now it only forwards request to the original handler. Later on this will become a point for conversion between internal types and thrift types. Underlying handler will be independent of rpc protocol types. -Created Handler interface for matching service -Previous Handler struct renamed to HandlerImpl -Created ThriftHandler wrapper on top of Handler interface. At this point it only forward requests as is to underlying handler. -Created Mock for Handler interface. -Covered ThriftHandler with units tests. Test that requests are forwarded to underlying handler and response is returned as is. -Replaced handler registration. Instead of registering HandlerImpl directly, wrap it with ThriftHandler and register it instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Replaced handler registration. Instead of registering HandlerImpl directly, wrap it with ThriftHandler and register it instead.
Why?
This is purely a mechanical refactoring that introduces additional ThriftHandler wrapper. For now it only forwards request to the original handler. Later on this will become a point for conversion between internal types and thrift types. Underlying handler will be independent of rpc protocol types.
How did you test it?
Potential risks
None, purely mechanical change.