Add getters to internal generated types #3650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
force-pushed
the
internal_types_getters
branch
from
4de56fa to
e506159
Compare
anish531213
approved these changes
Oct 14, 2020
github-actions
bot
force-pushed
the
internal_types_getters
branch
2 times, most recently
from
48dc0dc to
61203b4
Compare
github-actions
bot
force-pushed
the
internal_types_getters
branch
from
c487428 to
803b845
Compare
github-actions bot
pushed a commit
to vytautas-karpavicius/cadence
that referenced
this pull request
Feb 4, 2021
yux0
pushed a commit
to yux0/cadence
that referenced
this pull request
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds getters to internal types. This is needed because we are attempting to move from generated thrift types to internal types and in some places in the code we use thrift accessors. The purpose of these generated getters is to do the same thing that the thrift access methods