Fix throttling burst and add debug logs #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vancexu
reviewed
Jan 26, 2018
| @@ -627,9 +627,10 @@ func (s *matchingEngineSuite) TestConcurrentPublishConsumeActivitiesWithZeroDisp | |||
| const taskCount = 100 | |||
| s.matchingEngine.metricsClient = metrics.NewClient(tally.NewTestScope("test", nil), metrics.Matching) | |||
| throttleCt := s.concurrentPublishConsumeActivities(workerCount, taskCount, dispatchLimitFn) | |||
| s.logger.Infof("Number of tasks throttled: %d", throttleCt) | |||
There was a problem hiding this comment.
What should throttleCt be? If it only needs to be >= 1, I would just remove this log.
There was a problem hiding this comment.
Right now, I test for anything non-zero since it's hard to determine the exact number. The log line is there more for the flaky test. I don't believe it should be flaky anymore but if it is, it's good to see this in the log.
vancexu
reviewed
Jan 26, 2018
service/matching/service.go
Outdated
| @@ -55,7 +55,7 @@ func NewConfig() *Config { | |||
| UpdateAckInterval: 10 * time.Second, | |||
| OutstandingTaskAppendsThreshold: 250, | |||
| MaxTaskBatchSize: 100, | |||
| MinTaskThrottlingBurstSize: 10000, | |||
| MinTaskThrottlingBurstSize: 1, | |||
There was a problem hiding this comment.
test change or final value?
There was a problem hiding this comment.
Final value. I did some more research to understand this and having a high burst size would allow a burst of say 10000 requests in an instant which is not what we want. If you're interested, I can explain more offline.
vancexu
approved these changes
Jan 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.