Fix CreateWorkflowModeContinueAsNew for SQL #5413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidporter-id-au
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Update CreateWorkflowModeContinueAsNew of SQL to check if the run ID from the request matches the current run ID.
And also makes the behavior the same as NoSQL implementation, see https://github.com/uber/cadence/blob/v1.2.4/common/persistence/nosql/nosqlExecutionStoreUtil.go#L715
Why?
This is to make sure the behavior is the same as NoSQL implementation. And without this check, concurrent workflow resets could result in multiple open workflows with the same workflow id, and one of them will get stuck forever.
How did you test it?
eyeball check,
Potential risks
Release notes
Documentation Changes