Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visibility mode for admin when use Pinot visibility #5441

Merged
merged 2 commits into from
Nov 4, 2023
Merged

Conversation

neil-xie
Copy link
Member

@neil-xie neil-xie commented Nov 3, 2023

What changed?
Fix the visibility mode for admin to use both ES/Pinot when run admin commands such as delete
This only affects the admin when use Pinot visibility

Why?
Currently it can not delete from ES when use Pinot visibility

How did you test it?
Manual test in dev2

Potential risks

Release notes

Documentation Changes

Copy link
Member

@bowenxia bowenxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neil-xie neil-xie merged commit e64cd2c into master Nov 4, 2023
16 checks passed
@neil-xie neil-xie deleted the CDNC_6080 branch November 4, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants