Add unit test for cassandra workflow utils part-3 #5506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylanisikdemir
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx and
demirkayaender
as code owners
3vilhamster
reviewed
Dec 20, 2023
| }, | ||
| deleteInfos: []string{"timer2"}, | ||
| wantQueries: []string{ | ||
| `UPDATE executions SET timer_map[ timer1 ] = {` + |
There was a problem hiding this comment.
I'm a bit unsure, but for me it looks like these tests are testing both updateTimerInfos and custom implementation of FakeBatcher.
I'm not sure we can guarantee that this queries are what will be executed by Cassandra, since this is a simplified stub.
There was a problem hiding this comment.
That's right and that's actually the scope of unit tests. Basically the function under test takes a gocql.Batch interface and calls it with certain parameters. Test is validating this part. What is out of scope for these unit tests is the actual queries generated by the concrete implementation of 3rd party cql package which should be a concern of integration test
3vilhamster
approved these changes
Dec 20, 2023
taylanisikdemir
force-pushed
the
taylan/workflow_utils_test_part3
branch
from
6b74d2f to
4d1297c
Compare
taylanisikdemir
merged commit ed873b8
into
cadence-workflow:master
14 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Continuing from where I left in #5480