Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for error injection clients #5515

Merged

Conversation

3vilhamster
Copy link
Contributor

@3vilhamster 3vilhamster commented Dec 20, 2023

What changed?
Improving test coverage for error injection wrappers.
Persistence layer exposes error injection wrappers around all of the provided interfaces.
All wrappers follows the same logic and returns error on a provided rate, with extra logic for Timeout and Unhandled errors that are bypassing the wrapper.
I've added generation logic so these wrappers now autogenerated and moved all the wrapper into a separate package, separated them by type and provided a common tests form 0 rate, 100 rate and underlying errors.

Test coverage now is on 98%.

Why?
Improving test coverage and code readability.

How did you test it?
Unit tests.

Potential risks

Release notes

Documentation Changes

@3vilhamster 3vilhamster force-pushed the injection_error_tests branch from c2d66c0 to c521af7 Compare December 21, 2023 17:24
@3vilhamster 3vilhamster enabled auto-merge (squash) December 21, 2023 17:29
@3vilhamster 3vilhamster force-pushed the injection_error_tests branch from 0b6bda2 to cf36bbb Compare December 21, 2023 17:35
@3vilhamster 3vilhamster merged commit 1c2df58 into cadence-workflow:master Dec 21, 2023
16 checks passed
@3vilhamster 3vilhamster deleted the injection_error_tests branch December 21, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants