Fix multiple lock acquire on membership update #5576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3vilhamster
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
3vilhamster
force-pushed
the
improve-hashring
branch
from
dd46d5c to
0fae3f4
Compare
Groxx
reviewed
Jan 4, 2024
Groxx
approved these changes
Jan 4, 2024
taylanisikdemir
approved these changes
Jan 4, 2024
Groxx
reviewed
Jan 4, 2024
common/membership/hashring_test.go
Outdated
| @@ -31,7 +31,6 @@ import ( | |||
|
|
|||
| "github.com/golang/mock/gomock" | |||
| "github.com/stretchr/testify/assert" | |||
|
|
|||
There was a problem hiding this comment.
ah. this is the non-clean-code issue. just missing a fmt.
3vilhamster
force-pushed
the
improve-hashring
branch
from
0fae3f4 to
17758a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Membership ring on refresh need to update the ring members information. This was done one by one, even though it could be done in 1 operation.
I've switched to a single operation that does a single lock acquire on update.
No logical changes.
Why?
To decrease chances of seeing errors like "Failed to send listener notification, chanel is full".
How did you test it?
unit tests.
Potential risks
Release notes
Documentation Changes