Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a sample call to TaskValidator in update workflow cycle #5634

Merged
merged 6 commits into from
Feb 1, 2024

Conversation

agautam478
Copy link
Contributor

@agautam478 agautam478 commented Jan 29, 2024

What changed?
Made some dummy calls and updated the TaskValidation function to. make it compatible with the execution context.
The code is ready to be handed over to the future devs of this feature.

Added a dynamic config variable in order to control these calls on the basis of the domain ID.

Why?
The changes are made to test the TaskValidatiion functionality, see it's feasibility in the update flow and to prepare a dummy call instance so that it can be enabled right away.

How did you test it?
Yes. The feature comes with a unit test.

Potential risks
NA

Release notes
NA

Documentation Changes
NA

@agautam478 agautam478 marked this pull request as draft January 29, 2024 18:33
@agautam478 agautam478 changed the title Adding a sample call to TaskValidator in update workflow cycle {WIP} Adding a sample call to TaskValidator in update workflow cycle Jan 29, 2024
@agautam478 agautam478 changed the title {WIP} Adding a sample call to TaskValidator in update workflow cycle Adding a sample call to TaskValidator in update workflow cycle Jan 29, 2024
@agautam478 agautam478 marked this pull request as ready for review January 29, 2024 19:26
@agautam478 agautam478 requested a review from neil-xie January 30, 2024 21:30
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018d65eb-5d8b-43a6-a191-9c3bc14cb586

  • -11 of 22 (50.0%) changed or added relevant lines in 2 files are covered.
  • 48 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.02%) to 62.721%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/history/execution/context.go 0 11 0.0%
Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 89.05%
service/history/execution/context.go 1 69.81%
common/persistence/sql/common.go 2 72.73%
common/persistence/sql/sqlplugin/mysql/db.go 2 83.33%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
common/util.go 2 91.69%
service/history/task/fetcher.go 2 85.57%
service/matching/taskListManager.go 2 79.7%
service/history/task/cross_cluster_task_processor.go 8 80.79%
common/taskvalidator/validateworkflow.go 11 67.5%
Totals Coverage Status
Change from base Build 018d6588-230d-4a34-870a-29b5fd08321e: 0.02%
Covered Lines: 92244
Relevant Lines: 147070

💛 - Coveralls

@agautam478 agautam478 merged commit ebbc603 into cadence-workflow:master Feb 1, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants